Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 19, 2016, 14:30 UTC
Message-ID: <CACsJy8AswJb1wzV+mcQ3HXrib3HRtVje7PPd9AWPE9Bi32_2sw@mail.gmail.com>
In-Reply-To: <20161219140535.ehrbosgn32nl27ki@sigill.intra.peff.net>

On Mon, Dec 19, 2016 at 9:05 PM, Jeff King <peff@peff.net> wrote:

Show 19 quoted lines

> On Mon, Dec 19, 2016 at 08:53:30PM +0700, Duy Nguyen wrote:
>
>> >> Your commit message does not make clear if you want this "fatal" to be
>> >> grep-able (by scripts) or not. If not, please _() the string.  Maybe
>> >> this to reduce work for translators
>> >>
>> >>       /* TRANSLATORS: this is the prefix before usage error */
>> >>       fprintf(stderr, "%s %s\n\n", _("fatal:"), msg);
>> >
>> > I don't think we translate any of our "fatal:", "error:", etc, do we?
>> > It certainly doesn't look like it in usage.c.
>>
>> I know. But those existed before the l10n starts, some of those belong
>> to plumbing messages. This one is new.
>
> We add lots of new messages which are themselves translated, and they
> still get untranslated prefixes. It seems like consistency is more
> important than translating this one spot. But then, I do not use a
> translated git myself, so I would not see the difference either way.

I'm kinda used to the half English half Vietnamese messages after so many years (not just git). I do like the prefix translated as well. But I guess we could leave this a is for now. At least we know the scope of this message and will have easier time i18n-izing it when we do the same for die(), warning() and friends.

-- 
Duy