Re: [PATCH] parse-options: print "fatal:" before usage_msg_opt()

From: Duy Nguyen <pclouds@gmail.com>
Date: Dec 19, 2016, 12:07 UTC
Message-ID: <20161219120719.GF24125@ash>
In-Reply-To: <20161214151009.4wdzjb44f6aki5ug@sigill.intra.peff.net>

On Wed, Dec 14, 2016 at 10:10:10AM -0500, Jeff King wrote:

Show 10 quoted lines

> diff --git a/parse-options.c b/parse-options.c
> index 312a85dbd..4fbe924a5 100644
> --- a/parse-options.c
> +++ b/parse-options.c
> @@ -661,7 +661,7 @@ void NORETURN usage_msg_opt(const char *msg,
>  		   const char * const *usagestr,
>  		   const struct option *options)
>  {
> -	fprintf(stderr, "%s\n\n", msg);
> +	fprintf(stderr, "fatal: %s\n\n", msg);

Your commit message does not make clear if you want this "fatal" to be grep-able (by scripts) or not. If not, please _() the string. Maybe this to reduce work for translators

	/* TRANSLATORS: this is the prefix before usage error */
	fprintf(stderr, "%s %s\n\n", _("fatal:"), msg);

Show 5 quoted lines

>  	usage_with_options(usagestr, options);
>  }
>  
> -- 
> 2.11.0.341.g202cd3142