Re: [PATCH] commit: check return value of lookup_commit()

From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Aug 17, 2011, 01:32 UTC
Message-ID: <CACsJy8An1HwDkH86DoL2Kd9jfaD1cTkBN8sn=vfeHYVLbr0jAA@mail.gmail.com>
In-Reply-To: <7vy5ytgrps.fsf@alter.siamese.dyndns.org>

On Wed, Aug 17, 2011 at 1:02 AM, Junio C Hamano >> But then I would need to avoid die()ing in "initial_commit" case.

Show 19 quoted lines

>
> That's exactly what I said.
>
>        if (!initial)
>                /* we need to know the head_commit */
>                head_commit = lookup_and_check(HEAD);
>
>        /* depending on what kind of commit, we need different stuff */
>        if (initial)
>                ... going to create a parentless commit
>        else if (amending)
>                ... use the head_commit to learn parent, reuse the message
>                ... from there
>        else if ...
>
> These two are independent if/else cascades in the sense that the first is
> about learning the details of head_commit, and the latter is about
> learning how the commit is done, and in a subset of the latter head_commit
> is used.

And some months from now, someone may add more code in between the two "if" blocks. Some more months past, someone tweaks the "if (initial)" block but forgets to also update the "if (!initial)" above. This is what I want to avoid.

-- 
Duy