Should --pretty=format:%b respect i18n.logoutputencoding just like normal "git log"?
- From
Nguyen Thai Ngoc Duy <pclouds@gmail.com>
- Date
- Nov 19, 2012, 13:08 UTC
- Message-ID
- <CACsJy8Ag7wZCKeTM-fW7MUjWs=7xq7ciwhfx4kroJupwvs0dXg@mail.gmail.com>
Changes around this code in history is a bit unclear. User format learns to get log encoding from a field in 177b29d (pretty.c: teach format_commit_message() to reencode the output - 2010-11-02), but this field is only set for --fixup and --squash (in a few commits later). This makes "git log --pretty=format:%b" always ignore the output encoding config key. I don't think %b output should be different from normal log output, which does respect output encoding. Pat, any reasons not to do it?
-- Duy