threads / discuss / 32146

Should --pretty=format:%b respect i18n.logoutputencoding just like normal "git log"?

Subject: Should --pretty=format:%b respect i18n.logoutputencoding just like normal "git log"?

## tl;dr

2 messages between Nov 19, 2012 and Nov 19, 2012.

replies: 1people: 2as markdown or json

Nguyen Thai Ngoc Duy· Nov 19, 2012, 13:08 UTC · lore

Changes around this code in history is a bit unclear. User format learns to get log encoding from a field in 177b29d (pretty.c: teach format_commit_message() to reencode the output - 2010-11-02), but this field is only set for --fixup and --squash (in a few commits later). This makes "git log --pretty=format:%b" always ignore the output encoding config key. I don't think %b output should be different from normal log output, which does respect output encoding. Pat, any reasons not to do it?

-- 
Duy

Pat Notz· Nov 19, 2012, 17:42 UTC · re: Nguyen Thai Ngoc Duy · lore

Re: Should --pretty=format:%b respect i18n.logoutputencoding just like normal "git log"?

On Mon, Nov 19, 2012 at 6:08 AM, Nguyen Thai Ngoc Duy <pclouds@gmail.com> wrote:

Show 8 quoted lines

> Changes around this code in history is a bit unclear. User format
> learns to get log encoding from a field in 177b29d (pretty.c: teach
> format_commit_message() to reencode the output - 2010-11-02), but this
> field is only set for --fixup and --squash (in a few commits later).
> This makes "git log --pretty=format:%b" always ignore the output
> encoding config key. I don't think %b output should be different from
> normal log output, which does respect output encoding. Pat, any
> reasons not to do it?

Nope, that looks like it was an oversight on my part. Nice find.

~ Pat

> --
> Duy