Re: [ANNOUNCE] Git v2.22.0-rc1

From: Duy Nguyen <pclouds@gmail.com>
Date: May 21, 2019, 08:31 UTC
Message-ID: <CACsJy8AdhQH25NeDKKdSBctXcU=oyGcJ05XaNryj22GUQH5Btw@mail.gmail.com>
In-Reply-To: <87ef4svk1k.fsf@evledraar.gmail.com>

On Tue, May 21, 2019 at 5:27 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 21 quoted lines

>
>
> On Mon, May 20 2019, Bryan Turner wrote:
>
> > On Sun, May 19, 2019 at 10:00 AM Junio C Hamano <gitster@pobox.com> wrote:
> >>
> >>  * The diff machinery, one of the oldest parts of the system, which
> >>    long predates the parse-options API, uses fairly long and complex
> >>    handcrafted option parser.  This is being rewritten to use the
> >>    parse-options API.
> >
> > It looks like with these changes it's no longer possible to use "-U"
> > (or, I'd assume, "--unified") without adding an explicit number for
> > context lines.
> >
> > ...
>
> I don't know if argument-less -U was ever intended, but I think in light
> of what you're saying we should consider it a regression to fix before
> 2.22.0 is out. CC-ing Duy who wrote d473e2e0e8 ("diff.c: convert
> -U|--unified", 2019-01-27).

There should be no behavior change in this series. Period. I'm pretty sure I misread the old opt_arg() code and this is the result. --inter-hunk-context is also affected. I'm working on it.

> The bug there is that the old opt_arg() code would be torelant to empty
> values. I noticed a similar change the other day with the --abbrev
> option, but didn't think it was worth noting. Maybe it's a more general
> problem, in both cases we had a blindspot in our tests.

Hmm.. this one is different (at least it does not use opt_arg()). But I'll double check.

-- 
Duy