Re: New diff test failures on s390x architecture (was: [ANNOUNCE] Git v2.22.0-rc1)
- From
Todd Zullinger <tmz@pobox.com>
- Date
- May 23, 2019, 21:06 UTC
- Message-ID
- <20190523210627.GP3654@pobox.com>
- In-Reply-To
- <CACsJy8CY8CVVv1+s9sLtVEAhrC5Ki8NSY2qje8+se7VVudFo_g@mail.gmail.com>
Hi,
Duy Nguyen wrote:
Show 7 quoted lines
> On Fri, May 24, 2019 at 2:14 AM Todd Zullinger <tmz@pobox.com> wrote: >> I am guessing it's no coincidence that this only fails on >> s390x and it is the only big endian architecture in the >> fedora build system. > > I see a problem with -w and wrong type casting. sizeof(int) and > sizeof(long) on s390x are not the same, are they?
I don't believe so. I tested a small program which output sizeof(int) and sizeof(long). On s390x it's 4 bytes and 8 bytes, respectively (same as on x86_64). I hope that's the right way to test.
Thanks,
-- Todd