Re: [PATCH 0/8] Add 'ls-files --json' to dump the index in json
- From
Duy Nguyen <pclouds@gmail.com>
- Date
- Jun 21, 2019, 08:37 UTC
- Message-ID
- <CACsJy8AYw1QLjWALUNr7hSZemWyTSG0U8Fc_TH=9HNR-LcygTg@mail.gmail.com>
- In-Reply-To
- <20190619191709.GF28145@sigill.intra.peff.net>
On Thu, Jun 20, 2019 at 2:17 AM Jeff King <peff@peff.net> wrote:
> I think your warning in the manpage that this is for debugging is fine, > as it does not put us on the hook for maintaining the feature nor its > format forever. We might want to call it "--debug=json" or something,
Hmm.. does it mean we make --debug PARSE_OPT_OPTARG? In other words, "--debug" still means "text", --debug=json is obvious, but "--debug json" means "text" debug with pathspec "json". Which is really horrible in my opinion.
Or is it ok to just make the argument mandatory? That would be a behavior change, but I suppose --debug is a thing only we use and could still be a safe thing to do...
Show 5 quoted lines
> though, in case we do want real stable json support later (though of > course we would be free to steal the option then, since we're making no > promises). > > -Peff
-- Duy