Re: [PATCH 6/8] read-cache.c: dump "IEOT" extension as json

From: Duy Nguyen <pclouds@gmail.com>
Date: Jun 19, 2019, 13:24 UTC
Message-ID: <CACsJy8A1Zkkf-QxZSioD61UUj05Xap=f5NJLhOzabVc=dLz25A@mail.gmail.com>
In-Reply-To: <8a56ac88-f3b9-c80d-441e-8e74eb64921d@gmail.com>

On Wed, Jun 19, 2019 at 8:18 PM Derrick Stolee <stolee@gmail.com> wrote:

Show 12 quoted lines

>
> On 6/19/2019 5:58 AM, Nguyễn Thái Ngọc Duy wrote:> @@ -2266,7 +2271,7 @@ int do_read_index(struct index_state *istate, const char *path, int must_exist)
> >        * to multi-thread the reading of the cache entries.
> >        */
> >       if (extension_offset && nr_threads > 1)
> > -             ieot = read_ieot_extension(mmap, mmap_size, extension_offset);
> > +             ieot = read_ieot_extension(mmap, mmap_size, extension_offset, NULL);
>
> I tried applying this series on top of v2.22.0 and ran into an issue
> on this patch, and the message seemed to imply the problem was at this
> block. I couldn't figure out what was wrong, but maybe the series is
> based on a different commit?

it's on 'master', a6a95cd1b4 (The second batch, 2019-06-17). There are a couple patches since v2.22.0 that touch read-cache.c, but they don't touch these lines explictly...

-- 
Duy