Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

From: Duy Nguyen <pclouds@gmail.com>
Date: Oct 8, 2013, 09:44 UTC
Message-ID: <CACsJy8AQ-719sbUfJW98q_HYit7ePfB6oN3v7XTX6fvC7HnixA@mail.gmail.com>
In-Reply-To: <1381221884-27048-1-git-send-email-cmn@elego.de>

On Tue, Oct 8, 2013 at 3:44 PM, Carlos Martín Nieto <cmn@elego.de> wrote:

Show 10 quoted lines

> diff --git a/send-pack.c b/send-pack.c
> index 7d172ef..7b88ac8 100644
> --- a/send-pack.c
> +++ b/send-pack.c
> @@ -205,6 +205,8 @@ int send_pack(struct send_pack_args *args,
>                 quiet_supported = 1;
>         if (server_supports("agent"))
>                 agent_supported = 1;
> +       if (!server_supports("thin-pack"))
> +               args->use_thin_pack = 0;

Hmm.. I think this introduces a regression in C Git because receive-pack never advertises "thin-pack" and so "git push" from now on will never send thin packs. It's too late now to add thin-pack to receive-pack, perhaps a new extension "no-thin-pack" for those servers? Alternatively, just run git push --no-thin (you'll need f7c815c (push: respect --no-thin - 2013-08-12) though).

>         if (!remote_refs) {
>                 fprintf(stderr, "No refs in common and none specified; doing nothing.\n"

-- 
Duy