Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it

From: Carlos Martín Nieto <cmn@elego.de>
Date: Oct 19, 2013, 15:19 UTC
Message-ID: <1382195987.17156.7.camel@centaur.cmartin.tk>
In-Reply-To: <20131008222215.GI9464@google.com>

On Tue, 2013-10-08 at 15:22 -0700, Jonathan Nieder wrote:

Show 11 quoted lines

> Duy Nguyen wrote:
> 
> > Or maybe it's not that late. How about you go with your patch and add
> > thin-pack capability to receive-pack too?
> >
> > When new "git push" is used against old server, thin pack is disabled.
> > But that's not a big deal (I hope).
> 
> Could we have separate patches to introduce the server-side capability
> and then to request it in the client?  That way, people with old
> servers can apply the patch introducing the capability if they want.

That could work.

> 
> The new meaning of the "thin-pack" capability should also be
> documented in Documentation/technical/protocol-capabilities.txt.

Oh, right; the capability as described is only about the server being able to generate a thin pack. Wouldn't his mean that git shouldn't assume that *any* remote can fix thin packs, though? (other than most servers you do talk to happen to).

Anyway, facts on the ground and all that. I'll prepare some

> 
> Done that way and with enough time between the server advertising the
> capability and the client looking for it, it seems like a good idea.

If such patches would be accepted, that would be great. By the time this all gets merged, we might have thin pack fixing merged into libgit2, but there will still be uses where fixing them isn't an issue due to other constraints.

Cheers,
   cmn