git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: About my git workflow; maybe it's useful for others

From
Thiago Farina <tfransosi@gmail.com>
Date
Apr 22, 2015, 19:38 UTC
Message-ID
<CACnwZYf6-Fh0JZeJZ4j3QOyqRF_2-NKJB06Wh20ipsRmrRN+qw@mail.gmail.com>
In-Reply-To
<CAGZ79kaK-uRAE9-rH=-5t8djAw5e9rwkPjZuw=+XWEq+V6R5Yg@mail.gmail.com>
On Mon, Dec 29, 2014 at 10:22 PM, Stefan Beller <sbeller@google.com> wrote:
Show 33 quoted lines
> Hi,
>
> so I have been sending commits to the git mailing list occasionally
> for quite some time. In the last couple of weeks I send more and more
> patches to the mailing list as it's part of my job now. Here is a
> collection of practices I am following (or want to follow) and they
> seem to be effective.
>
> Most of this is already documented in various documents in Documentation/*
> and this email is no news for the regular contributors. It may help new comers
> though.
>
> * Split patches up into logical pieces as you go.
>
> It's easy to go wild and after hours of hacking you have implemented a cool new
> feature. This the natural flow of hacking as it's the most fun. But
> this approach
> is not easy to be reviewed. So let me explain how reviewing works in
> the git project.
>
>         Reviewing works in the git project is quite liberal, anybody
> is encouraged to
>         comment on patches flying by. Junio, the maintainer then
> decides which patches
>         he picks up and merges them into the various stages of git
> (pu, next, master, maint).
>         The decision which patches are worth for inclusion is based on
> the amount of discussion
>         by the community and generally a patch only makes it if a
> concensus is met.
>
> * git send-email is the only email client I trust for sending patches
>
IMO, sending email is the easiest part.

The hard begins when you have to edit your patch and resend with the reviewers' feedback incorporated. For me that is the most tricky and hard part to get right, specially when using GMail as an email client.

How do you handle that part of the process?
-- 
Thiago Farina
Previous: Stefan BellerNext: Stefan Beller
Message 2 of 5 in “About my git workflow; maybe it's useful for others”
  1. Stefan BellerDec 30, 2014
  2. Thiago FarinaApr 22, 2015
  3. Stefan BellerApr 22, 2015
  4. Thiago FarinaApr 22, 2015
  5. Stefan BellerApr 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.