Re: [PATCH 1/1] add: use advise function to display hints
- From
Heba Waly <heba.waly@gmail.com>
- Date
- Jan 7, 2020, 10:54 UTC
- Message-ID
- <CACg5j27ce5BfR9RKekMEXokvCnXiXzmCVsyEKce+HORe8kL_GQ@mail.gmail.com>
- In-Reply-To
- <xmqqzhf5cw69.fsf@gitster-ct.c.googlers.com>
On Fri, Jan 3, 2020 at 11:48 AM Junio C Hamano <gitster@pobox.com> wrote:
Show 28 quoted lines
>
> Junio C Hamano <gitster@pobox.com> writes:
>
> A side note.
>
> Right now, the advise() API is a bit awkweard to use correctly.
> When introducing a new advice message, you would
>
> * come up with advice.frotz configuration variable
>
> * define and declare advice_frotz global variable that defaults to
> true
>
> * sprinkle calls like this:
>
> if (advice_frotz)
> advise(_("helpful message about frotz"));
>
> I am wondering about two things:
>
> (1) if we can update the API so that the above can be reduced to
> just adding calls like:
>
> advise_ng("frotz", _("helpful message about frotz"));
>
> (2) if such a simplified advise_ng API is a good idea to begin
> with.
>That's a valid suggestion, I can investigate that in a new patch, I'd rather keep this one as simple as calling the existing advise function.
Thanks,
Heba