Re: [PATCH 1/1] add: use advise function to display hints
- From
Emily Shaffer <emilyshaffer@google.com>
- Date
- Jan 6, 2020, 23:07 UTC
- Message-ID
- <20200106230712.GA181522@google.com>
- In-Reply-To
- <90608636bf184de76f91e4e04d9e796a021775a0.1577934241.git.gitgitgadget@gmail.com>
On Thu, Jan 02, 2020 at 03:04:01AM +0000, Heba Waly via GitGitGadget wrote:
Show 8 quoted lines
> From: Heba Waly <heba.waly@gmail.com>
>
> @@ -390,7 +390,7 @@ static int add_files(struct dir_struct *dir, int flags)
> fprintf(stderr, _(ignore_error));
> for (i = 0; i < dir->ignored_nr; i++)
> fprintf(stderr, "%s\n", dir->ignored[i]->name);
> - fprintf(stderr, _("Use -f if you really want to add them.\n"));
> + advise(_("Use -f if you really want to add them.\n"));In the vein of the rest of your project, for me I'd rather see a copy-pasteable response here:
"Use 'git add -f " + name + "' if you really want to add them."
That is, if you know the name of the file that was being added here, you could provide it so the user can simply copy and go, rather than retyping.
- Emily