Re: [PATCH v2 2/4] git-credential-store: support XDG_CONFIG_HOME

From: Paul Tan <pyokagan@gmail.com>
Date: Mar 10, 2015, 13:43 UTC
Message-ID: <CACRoPnRoY=c5NukCCS0OPMaL1TvqSuSL036-mK+4sae_6VgrVA@mail.gmail.com>
In-Reply-To: <1425801532-8483-3-git-send-email-pyokagan@gmail.com>

On Sun, Mar 8, 2015 at 3:58 PM, Paul Tan <pyokagan@gmail.com> wrote:

Show 6 quoted lines

>                 remove_credential(&fns, &c);
>         else if (!strcmp(op, "store"))
> -               store_credential(&fns, &c, fns.nr - 1);
> +               store_credential(&fns, &c, 0);
>         else
>                 ; /* Ignore unknown operation. */

Whoops, seems like I squashed some commits in the wrong order (but there is no functional difference). Will re-roll the patch series.

Also, store_credential() should take a string as the default filename instead of an index into the filename string_list for extra API flexibility.

Thanks.