Re: [PATCH v2 4/4] t0302: test credential-store support for XDG_CONFIG_HOME

From: Paul Tan <pyokagan@gmail.com>
Date: Mar 10, 2015, 13:55 UTC
Message-ID: <CACRoPnRXH7ozCvdxLORKMAw=GwK65NzTd-e7qtvKiQHu-qAs=Q@mail.gmail.com>
In-Reply-To: <vpqk2yqcppi.fsf@anie.imag.fr>

On Mon, Mar 9, 2015 at 8:36 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 5 quoted lines

> Paul Tan <pyokagan@gmail.com> writes:
>> +'
>> +test_expect_success 'xdg credentials file will not be created if it does not exist' '
>
> We usually put a blank line between tests.

Okay, will do that.

>> +helper_test store
>
> That seems a bit "brute force" to me to re-run all tests several times.
> It's probably OK since the tests are quite fast though.

The credential helper tests are re-run because I believe that tests should make no assumptions on the underlying implementation. e.g. the presence of the xdg file only may activate a code path that causes credential storage to succeed but retrieval to fail.

Show 6 quoted lines

>> +test_expect_success 'set up custom XDG_CONFIG_HOME credential file' '
>> +     XDG_CONFIG_HOME="$HOME/xdg" && export XDG_CONFIG_HOME &&
>> +     mkdir -p "$HOME/xdg/git" &&
>
> I'd spell that "$XDG_CONFIG_HOME"/git instead, but that's not really
> important.

Okay, will do that.

Thanks for the review.