Re: [PATCH v4 0/4] refs: run copy and rename through transactions
- From
Maciej Ciemborowicz <maciej.ciemborowicz@gmail.com>
- Date
- Oct 8, 2026, 10:43 UTC
- Message-ID
- <CACQ=SRGtpYLCcAaJz+yUR564wTm8wsMy1qn7hZ_iJfDTc_KTeQ@mail.gmail.com>
- In-Reply-To
- <asdsIjNEUOpaAnX5@pks.im>
On Thu, Oct 8, 2026 at 12:10 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 6 quoted lines
> Please engage with the reviewers. Just posting new versions without > replying to them at all will very likely not get you anywhere. This kind > of behaviour is nowadays a red flag and often hints at contributors who > are basically just a meat proxy. And as a consequence, reviewers are > very likely to disengage and stop reviewing your patch series > altogether, which is frustrating to everyone involved.
I reproduced both failures. In v3, preparing the reflogs overwrote an earlier packed-refs preparation error with success. V4 jumps to cleanup on that error. I had not run t0600 or t5510 before submitting v3. Both now pass unchanged, and the full standard test suite passes on macOS with both files and reftable, based on 6de20f6092. Sorry for missing this before submission.
Thanks, Maciej