Re: [PATCH] refs: run copy and rename through transactions

From: Maciej Ciemborowicz <maciej.ciemborowicz@gmail.com>
Date: Sep 22, 2026, 13:08 UTC
Message-ID: <CACQ=SRGicdcnyP6mFifdZgzCgoSgDPA=yrkr2gSPQ6_s7GJKsw@mail.gmail.com>
In-Reply-To: <xmqqh5jijiar.fsf@gitster.g>

On Tue, Sep 22, 2026 at 1:28 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> More importantly, this structure suggests to me that you can have a
> single rename (or copy) from one source to one destination in a
> single transaction.  Is that correct or am I misunderstanding the
> way this data structure is used?  How would one rename A, B and C
> to X, Y and Z in a single transaction?  Or perhaps rename A to B
> and copy C to D in a single transaction?

Good point. The current design indeed makes copy/rename a property of the whole transacton, so it does not compose with multiple such operations. I'll rework it so that state belongs to individual updates instead. Unfortunately, I'll have to put this aside for a few days until I finish this first: https://lore.kernel.org/git/CACQ=SRHthWOLVXmY6wgknOPgpQ+oB1vV-Q0AL=mK9mXb2Xy9Nw@mail.gmail.com/T/#t

Thanks, Maciej Ciemborowicz