Re: [PATCH 3/7] Allow svnrdump_sim.py to be used with Python 2.2

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Apr 5, 2017, 13:40 UTC
Message-ID: <CACBZZX7_tH-Q6PWdj=2BryLnSw-dX__fuR8hvbwXG4sSaM61bg@mail.gmail.com>
In-Reply-To: <20170405130424.13803-4-tgc@jupiterrise.com>

On Wed, Apr 5, 2017 at 3:04 PM, Tom G. Christensen <tgc@jupiterrise.com> wrote:

> This allows running the git-svn testsuite with Python 2.2.

+CC-ing Eric S. Raymond who added these version limitations in a33faf2827.

Also, in his patch contrib/svn-fe/svnrdump_sim.py, git_remote_helpers/git/__init__.py & git-p4.py is set to >=2.4 or later.

Are you skipping those tests & they don't work under 2.2?

Show 24 quoted lines

> Signed-off-by: Tom G. Christensen <tgc@jupiterrise.com>
> ---
>  contrib/svn-fe/svnrdump_sim.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/svn-fe/svnrdump_sim.py b/contrib/svn-fe/svnrdump_sim.py
> index 11ac6f692..86bf4a742 100755
> --- a/contrib/svn-fe/svnrdump_sim.py
> +++ b/contrib/svn-fe/svnrdump_sim.py
> @@ -8,9 +8,9 @@ to the highest revision that should be available.
>  import sys
>  import os
>
> -if sys.hexversion < 0x02040000:
> +if sys.hexversion < 0x02020000:
>      # The limiter is the ValueError() calls. This may be too conservative
> -    sys.stderr.write("svnrdump-sim.py: requires Python 2.4 or later.\n")
> +    sys.stderr.write("svnrdump-sim.py: requires Python 2.2 or later.\n")
>      sys.exit(1)
>
>
> --
> 2.12.2
>