git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] Should "log --cc" imply "log --cc -p"?

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 5, 2013, 14:27 UTC
Message-ID
<CACBZZX7JNwZYHn--Cp4g1rLPratJ9nEa-Q8HsYk65jjDYAkFqA@mail.gmail.com>
In-Reply-To
<20130205112249.GE24973@sigill.intra.peff.net>
On Tue, Feb 5, 2013 at 12:22 PM, Jeff King <peff@peff.net> wrote:
Show 22 quoted lines
> On Tue, Feb 05, 2013 at 11:16:52AM +0100, Ævar Arnfjörð Bjarmason wrote:
>
>> On Mon, Feb 4, 2013 at 5:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> > "git log/diff-files -U8" do not need "-p" to enable textual patches,
>> > for example.  It is "I already told you that I want 8-line context.
>> > For what else, other than showing textual diff, do you think I told
>> > you that for?" and replacing "8-line context" with various other
>> > options that affect patch generation will give us a variety of end
>> > user complaints that would tell us that C) is more intuitive to
>> > them.
>>
>> On a related note I think "--full-diff" should imply "-p" too.
>
> I don't think that is in the same class. --full-diff is quite useful for
> many other diff formats. E.g.:
>
>   git log --full-diff --raw Makefile
>
> If you are proposing to default to "-p" when "--full-diff" is used but
> no format is given, that is a slightly different thing. The --full-diff
> in such a case is indeed useless, but I do not think it necessarily
> follows that "-p" was what the user wanted.
You're right. I didn't notice that it could work with other things besides -p.

On a related note then, it's a bit confusing that it's called "--full-diff" when it doesn't actually show a diff.

Previous: Jeff KingNext: Junio C Hamano
Message 9 of 10 in “[RFC] Should "log --cc" imply "log --cc -p"?”
  1. Junio C HamanoFeb 3, 2013
  2. Michael J GruberFeb 4, 2013
  3. Junio C HamanoFeb 4, 2013
  4. Michael J GruberFeb 5, 2013
  5. Jeff KingFeb 5, 2013
  6. Junio C HamanoFeb 5, 2013
  7. Ævar Arnfjörð BjarmasonFeb 5, 2013
  8. Jeff KingFeb 5, 2013
  9. Ævar Arnfjörð BjarmasonFeb 5, 2013
  10. Junio C HamanoFeb 5, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.