git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] blame: output porcelain "previous" header for each file

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 27, 2017, 21:08 UTC
Message-ID
<CACBZZX5AnG=hpnZCG3qFkLOO0gbgvt79ZYP3-oG5VjE8p284cQ@mail.gmail.com>
In-Reply-To
<20170106042051.nwjiuyyp7ljhs4sr@sigill.intra.peff.net>
On Fri, Jan 6, 2017 at 5:20 AM, Jeff King <peff@peff.net> wrote:
Show 6 quoted lines
> +for output in porcelain line-porcelain
> +do
> +       test_expect_success "generate --$output output" '
> +               git blame --root -C --$output combined >output
> +       '
> +
The --root option isn't needed here, the tests pass if it's removed.

Discovered while looking at the sorry state of our blame test suite vis-a-vis tests for config, no tests for blame.showroot & blame.blankboundary.

I'll submit that eventually, but meanwhile did you mean to omit --root here, or is the test broken in some other way and it /should/ need --root but doesn't?

Previous: Junio C HamanoNext: Jeff King
Message 6 of 8 in “fixing some random blame corner cases”
  1. 0/3 fixing some random blame corner casesJeff King, Jan 6, 2017
  2. 2/3 blame: handle --no-abbrevJeff King, Jan 6, 2017
  3. 1/3 blame: fix alignment with --abbrev=40Jeff King, Jan 6, 2017
  4. 3/3 blame: output porcelain "previous" header for each fileJeff King, Jan 6, 2017
  5. Junio C HamanoJan 9, 2017
  6. Ævar Arnfjörð BjarmasonMar 27, 2017
  7. Jeff KingMar 27, 2017
  8. Junio C HamanoJan 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.