From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mon, 27 Mar 2017 21:08:08 GMT
Subject: Re: [PATCH 3/3] blame: output porcelain "previous" header for each file
Message-ID: <CACBZZX5AnG=hpnZCG3qFkLOO0gbgvt79ZYP3-oG5VjE8p284cQ@mail.gmail.com>
In-Reply-To: <20170106042051.nwjiuyyp7ljhs4sr@sigill.intra.peff.net>

On Fri, Jan 6, 2017 at 5:20 AM, Jeff King <peff@peff.net> wrote:

> +for output in porcelain line-porcelain
> +do
> +       test_expect_success "generate --$output output" '
> +               git blame --root -C --$output combined >output
> +       '
> +

The --root option isn't needed here, the tests pass if it's removed.

Discovered while looking at the sorry state of our blame test suite
vis-a-vis tests for config, no tests for blame.showroot &
blame.blankboundary.

I'll submit that eventually, but meanwhile did you mean to omit --root
here, or is the test broken in some other way and it /should/ need
--root but doesn't?