Re: [PATCH] git-svn: un-break "git svn rebase" when log.abbrevCommit=true
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jan 29, 2012, 03:12 UTC
- Message-ID
- <CACBZZX4_54LNqiEEA1BVvJFcLh_o=_ErHWGZMxSHTV2yTqte_Q@mail.gmail.com>
- In-Reply-To
- <20120129025914.GA5981@burratino>
On Sun, Jan 29, 2012 at 03:59, Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 21 quoted lines
> Ævar Arnfjörð Bjarmason wrote:
>
>> --- a/git-svn.perl
>> +++ b/git-svn.perl
>> @@ -1879,7 +1879,8 @@ sub cmt_sha2rev_batch {
>> sub working_head_info {
>> my ($head, $refs) = @_;
>> my @args = qw/log --no-color --no-decorate --first-parent
>> - --pretty=medium/;
>> + --pretty=medium --no-abbrev-commit --no-decorate/;
>> +
>
> Oh, dear. Wouldn't
>
> my @args = qw/rev-list --first-parent --pretty=medium/;
>
> be simpler and more robust as a quick fix?
>
> Of course something that takes plain rev-list --first-parent output
> and pipes it through to cat-file --batch might be more intuitive, but
> rev-list --pretty should at least work. ;-)That sounds like a better fix. I forgot that rev-list could emulate git-log like that.