Re: [PATCH] git-svn: un-break "git svn rebase" when log.abbrevCommit=true

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 29, 2012, 02:59 UTC
Message-ID: <20120129025914.GA5981@burratino>
In-Reply-To: <1327803073-7000-1-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

Show 9 quoted lines

> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1879,7 +1879,8 @@ sub cmt_sha2rev_batch {
>  sub working_head_info {
>  	my ($head, $refs) = @_;
>  	my @args = qw/log --no-color --no-decorate --first-parent
> -	              --pretty=medium/;
> +	              --pretty=medium --no-abbrev-commit --no-decorate/;
> +

Oh, dear.  Wouldn't

	my @args = qw/rev-list --first-parent --pretty=medium/;

be simpler and more robust as a quick fix?

Of course something that takes plain rev-list --first-parent output and pipes it through to cat-file --batch might be more intuitive, but rev-list --pretty should at least work. ;-)