git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] p7519: allow running without watchman prereq

From
NKNipunn Koorapati <nipunn@dropbox.com>
Date
Jan 4, 2021, 23:56 UTC
Message-ID
<CABVhGpUJhS_uq14p1SuhTt9x5c0rkmB_0sw9uSmce8+4WKATRw@mail.gmail.com>
In-Reply-To
<46b2e5af59c451b816973ba3f2c32a68639298b3.1609796006.git.me@ttaylorr.com>
> I could do without the 'else' block here, but it seems straightforward
> enough. Likewise, the "ensure no silent error" comment could certainly
> be removed (since 'test_must_be_empty error' makes what is happening
> quite clear), but the fix pursued here is minimal.

This looks great to me. Thanks for fixing - and appreciate the else clause here for the reader.

--Nipunn
Previous: Taylor Blau
Message 2 of 2 in “p7519: allow running without watchman prereq”
  1. p7519: allow running without watchman prereqTaylor Blau, Jan 4, 2021
  2. Nipunn KoorapatiJan 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.