From: Nipunn Koorapati Date: Mon, 04 Jan 2021 23:56:27 GMT Subject: Re: [PATCH] p7519: allow running without watchman prereq Message-ID: In-Reply-To: <46b2e5af59c451b816973ba3f2c32a68639298b3.1609796006.git.me@ttaylorr.com> > I could do without the 'else' block here, but it seems straightforward > enough. Likewise, the "ensure no silent error" comment could certainly > be removed (since 'test_must_be_empty error' makes what is happening > quite clear), but the fix pursued here is minimal. This looks great to me. Thanks for fixing - and appreciate the else clause here for the reader. --Nipunn