Re: [PATCH] git-difftool: allow skipping file by typing 'n' at prompt

From: Phil Hord <phil.hord@gmail.com>
Date: Oct 4, 2011, 18:02 UTC
Message-ID: <CABURp0qmYWRJzHZZwZreKnj0ymFyM_AYXWXqwy=vTZspoPvvvg@mail.gmail.com>
In-Reply-To: <7vbotwdbjg.fsf@alter.siamese.dyndns.org>

On Tue, Oct 4, 2011 at 11:25 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Sitaram Chamarty <sitaram@atc.tcs.com> writes:
>
>> Signed-off-by: Sitaram Chamarty <sitaram@atc.tcs.com>
>> ---
>>
>> I'm using what is pretty much a universal convention to
>> signify that the default choice is "y"; I hope documentation
>> for something so small is not needed but if it is, let me
>> know and I'll do that also.
>>
>> -                     printf "Hit return to launch '%s': " \
>> +                     printf "Launch '%s' [y]/n: " \
>
> I think I've seen this done as: "do this? [Y/n]" elsewhere.
>
> Not telling you what to do, but trying to feel what others may think.

I think so, too. The [y]/n syntax is not clear enough for me to confidently know what the default value will be.

Phil