Re: [PATCH] git-difftool: allow skipping file by typing 'n' at prompt

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 4, 2011, 19:28 UTC
Message-ID: <7vty7oblpu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CABURp0qmYWRJzHZZwZreKnj0ymFyM_AYXWXqwy=vTZspoPvvvg@mail.gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

Show 8 quoted lines

> On Tue, Oct 4, 2011 at 11:25 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> I think I've seen this done as: "do this? [Y/n]" elsewhere.
>>
>> Not telling you what to do, but trying to feel what others may think.
>
> I think so, too.  The [y]/n syntax is not clear enough for me to
> confidently know what the default value will be.

One downside of "do this [Y,n,m,o,p,q]? " is that it limits us to lowercase responses, which means we cannot assign 'q' for quitting from the innermost nested context and assign 'Q' for quitting from the whole interactive loop (e.g. "git add -p").

    "do this [y,n,m,o,p,q] (default=y)? "

may have been a better choice in hindsight.

No matter what we end up doing, let's try to be consistent.

Thanks.