git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] bundle: add parse_bundle_header() helper function

From
Phil Hord <phil.hord@gmail.com>
Date
Oct 14, 2011, 12:59 UTC
Message-ID
<CABURp0otqxeKjLe-Rk3htZRa0M7+rerfrbVrXx-7Dr1tK3tTTg@mail.gmail.com>
In-Reply-To
<7vliso34gc.fsf@alter.siamese.dyndns.org>
On Thu, Oct 13, 2011 at 6:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Move most of the code from read_bundle_header() to parse_bundle_header()
> that takes a file descriptor that is already opened for reading, and make
> the former responsible only for opening the file and noticing errors.
...
>  * It generally is a bad practice to base a non-RFC patch on an RFC one,
>   but in any case here is how I would do the is_bundle() helper.

I didn't label it RFC, but I did pose a question in the message section. Is there a rule for what marks something as RFC (if not the RFC label in the subject line)?

Your implementation looks fine to me.
Phil
Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 5 in “bundle: allowing to read from an unseekable fd”
  1. 1/2 bundle: allowing to read from an unseekable fdJunio C Hamano, Oct 13, 2011
  2. 2/2 bundle: add parse_bundle_header() helper functionJunio C Hamano, Oct 13, 2011
  3. Phil HordOct 14, 2011
  4. Junio C HamanoOct 14, 2011
  5. Phil HordOct 14, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.