From: Phil Hord <phil.hord@gmail.com>
Date: Fri, 14 Oct 2011 12:59:20 GMT
Subject: Re: [PATCH 2/2] bundle: add parse_bundle_header() helper function
Message-ID: <CABURp0otqxeKjLe-Rk3htZRa0M7+rerfrbVrXx-7Dr1tK3tTTg@mail.gmail.com>
In-Reply-To: <7vliso34gc.fsf@alter.siamese.dyndns.org>

On Thu, Oct 13, 2011 at 6:35 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Move most of the code from read_bundle_header() to parse_bundle_header()
> that takes a file descriptor that is already opened for reading, and make
> the former responsible only for opening the file and noticing errors.
...

>  * It generally is a bad practice to base a non-RFC patch on an RFC one,
>   but in any case here is how I would do the is_bundle() helper.

I didn't label it RFC, but I did pose a question in the message
section.  Is there a rule for what marks something as RFC (if not the
RFC label in the subject line)?

Your implementation looks fine to me.

Phil