Re: [PATCH v3 0/4] Batch prefetching
- From
Elijah Newren <newren@gmail.com>
- Date
- May 18, 2026, 16:55 UTC
- Message-ID
- <CABPp-BHzVW9zf6kzfrpcWBny3bW_J0KhkVkg5+RYiQ8ymv+OdA@mail.gmail.com>
- In-Reply-To
- <0da4f159-8d4b-49e2-93c1-25aa0bf69371@gmail.com>
On Mon, May 18, 2026 at 5:17 AM Derrick Stolee <stolee@gmail.com> wrote:
Show 13 quoted lines
> > On 5/14/2026 12:25 PM, Elijah Newren via GitGitGadget wrote: > > Changes since v2: > > > > * Modified the final patch as suggested by Stolee to include pathspec usage > > in the testcase > > * Modified the last two patches to not re-download blobs we already have > > locally, and adjusted the tests to verify > > * Inserted a new first patch, containing a documentation addition that > > would have helped me avoid making the above mistake in the first place. > > Thank you for these changes. I reviewed the updates and documentation and > think this version is good to go.
As always, thanks for reviewing! Your comments on patch 3 in particular led me to what would have been a rather annoying bug, so thanks for calling out an improvement to the testcase that alerted me to that issue.
Show 7 quoted lines
> > Note: Stolee also suggest some code sharing or code movement in his review > > of v2 2/3, but possibly based on a misunderstanding of v2 2/3 (that patch > > isn't about a diff) and it's not clear to me what could be shared or moved, > > so that's not part of this round. > > Your detailed responses in the v2 thread helped me understand that my thought > was misguided. Thanks for giving me extra confidence in your approach here.
I can totally see where the comments came from; they did seem logical on the surface. I knew the changes were cherry-specific in a few ways, but trying to figure out how to explain that and dig further into the details to find a good angle (and try to make sure I wasn't just missing something about how part of the logic could be shared) took a bunch of additional time, so I'm happy to hear that others consider it enlightening. That makes it time well spent.