git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/4] Batch prefetching

From
Elijah Newren <newren@gmail.com>
Date
May 18, 2026, 16:55 UTC
Message-ID
<CABPp-BHzVW9zf6kzfrpcWBny3bW_J0KhkVkg5+RYiQ8ymv+OdA@mail.gmail.com>
In-Reply-To
<0da4f159-8d4b-49e2-93c1-25aa0bf69371@gmail.com>
On Mon, May 18, 2026 at 5:17 AM Derrick Stolee <stolee@gmail.com> wrote:
Show 13 quoted lines
>
> On 5/14/2026 12:25 PM, Elijah Newren via GitGitGadget wrote:
> > Changes since v2:
> >
> >  * Modified the final patch as suggested by Stolee to include pathspec usage
> >    in the testcase
> >  * Modified the last two patches to not re-download blobs we already have
> >    locally, and adjusted the tests to verify
> >  * Inserted a new first patch, containing a documentation addition that
> >    would have helped me avoid making the above mistake in the first place.
>
> Thank you for these changes. I reviewed the updates and documentation and
> think this version is good to go.

As always, thanks for reviewing! Your comments on patch 3 in particular led me to what would have been a rather annoying bug, so thanks for calling out an improvement to the testcase that alerted me to that issue.

Show 7 quoted lines
> > Note: Stolee also suggest some code sharing or code movement in his review
> > of v2 2/3, but possibly based on a misunderstanding of v2 2/3 (that patch
> > isn't about a diff) and it's not clear to me what could be shared or moved,
> > so that's not part of this round.
>
> Your detailed responses in the v2 thread helped me understand that my thought
> was misguided. Thanks for giving me extra confidence in your approach here.

I can totally see where the comments came from; they did seem logical on the surface. I knew the changes were cherry-specific in a few ways, but trying to figure out how to explain that and dig further into the details to find a good angle (and try to make sure I wasn't just missing something about how part of the logic could be shared) took a bunch of additional time, so I'm happy to hear that others consider it enlightening. That makes it time well spent.

Previous: Junio C Hamano
Message 29 of 29 in “Batch prefetching”
  1. 0/3 Batch prefetchingElijah Newren via GitGitGadget, Apr 16, 2026
  2. 1/3 patch-ids.h: add missing trailing parenthesis in documentation commentElijah Newren via GitGitGadget, Apr 16, 2026
  3. 2/3 builtin/log: prefetch necessary blobs for `git cherry`Elijah Newren via GitGitGadget, Apr 16, 2026
  4. Junio C HamanoApr 17, 2026
  5. Elijah NewrenApr 17, 2026
  6. 3/3 grep: prefetch necessary blobsElijah Newren via GitGitGadget, Apr 16, 2026
  7. 0/3 Batch prefetchingElijah Newren via GitGitGadget, Apr 18, 2026
  8. 1/3 patch-ids.h: add missing trailing parenthesis in documentation commentElijah Newren via GitGitGadget, Apr 18, 2026
  9. 2/3 builtin/log: prefetch necessary blobs for `git cherry`Elijah Newren via GitGitGadget, Apr 18, 2026
  10. Phillip WoodApr 19, 2026
  11. Elijah NewrenApr 21, 2026
  12. Phillip WoodApr 23, 2026
  13. Elijah NewrenApr 23, 2026
  14. Derrick StoleeApr 27, 2026
  15. Junio C HamanoMay 11, 2026
  16. Elijah NewrenMay 11, 2026
  17. Elijah NewrenMay 13, 2026
  18. Derrick StoleeMay 18, 2026
  19. 3/3 grep: prefetch necessary blobsElijah Newren via GitGitGadget, Apr 18, 2026
  20. Derrick StoleeApr 27, 2026
  21. Elijah NewrenMay 13, 2026
  22. 0/4 Batch prefetchingElijah Newren via GitGitGadget, May 14, 2026
  23. 1/4 promisor-remote: document caller filtering contractElijah Newren via GitGitGadget, May 14, 2026
  24. 2/4 patch-ids.h: add missing trailing parenthesis in documentation commentElijah Newren via GitGitGadget, May 14, 2026
  25. 3/4 builtin/log: prefetch necessary blobs for `git cherry`Elijah Newren via GitGitGadget, May 14, 2026
  26. 4/4 grep: prefetch necessary blobsElijah Newren via GitGitGadget, May 14, 2026
  27. Derrick StoleeMay 18, 2026
  28. Junio C HamanoMay 18, 2026
  29. Elijah NewrenMay 18, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.