Re: [PATCH v2 2/3] builtin/log: prefetch necessary blobs for `git cherry`
- From
Elijah Newren <newren@gmail.com>
- Date
- May 11, 2026, 17:45 UTC
- Message-ID
- <CABPp-BFdYjnjhSrjEBf8kjYYY2jtrQ_=w0jYR+DDWh3szmtvqQ@mail.gmail.com>
- In-Reply-To
- <xmqqtsseu09t.fsf@gitster.g>
On Sun, May 10, 2026 at 7:51 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 35 quoted lines
> > Derrick Stolee <stolee@gmail.com> writes: > > > Ultimately, _this_ patch cares about a diff. Could we compute a > > "diff prep" computation using the core diff library instead of > > inventing a second queue of results for diffing? > > > > Patch 3 cares about a "scan prep" which cares about loading all > > blobs for a given tree with respect to a pathspec. This is very > > similar to what a checkout would do, though it ultimately uses > > a form of diff to find out what change should be applied to the > > working directory. Perhaps 'git archive' is a better matching > > example. > > > > I don't mean to make your series more complicated. I value what > > you're doing and can see how your current attention can be used > > to make further improvements later. By implementing things in a > > common location, then we can have later integrations add to the > > confidence in the feature through tests covering each user-facing > > use. > > > > I'm not sure if it makes sense to attempt to create a universal > > library method that would be used by builtin/log.c _and_ diff.c, > > at least not right now. I'm most interested in having this logic > > be more reusable in the future without needing to move code > > across files. > > The points raised in the message I am responding here, together with > the ones in <31763514-2602-4d8e-ac25-70590f090947@gmail.com>, remain > unanswered. > > Should I still keep these patches in my tree, hoping that responses > may come some day? I will mark the topic as "Expeting review > responses" in the draft "What's cooking" report I work from for now, > but it has been quite a while since we looked at the patches, so...?
Sorry for not responding sooner. There have been a number of incidents at work (including a big problematic one the day Derrick sent his email), and I was pulled into both firefighting and remediation duties which have sucked up all my time. I owe responses to Derrick, Patrick, Johannes, Phillip, and Taylor on a variety of topics.
For this particular series, maybe mark as expecting a re-roll, since Stolee suggested adding a test on patch 3?