git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: implement config.diff.renames=copies-harder

From
Elijah Newren <newren@gmail.com>
Date
Nov 8, 2023, 04:38 UTC
Message-ID
<CABPp-BHqJ0o85H7nBbPJ0b4kXvWF7TMCrTzpxhWfSHSrfGf7dQ@mail.gmail.com>
In-Reply-To
<xmqqv8ac7utk.fsf@gitster.g>
On Tue, Nov 7, 2023 at 8:06 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 20 quoted lines
>
> Elijah Newren <newren@gmail.com> writes:
>
> >> > We probably don't want to copy all three of those sentences here, but
> >> > I think we need to make sure users can find them, thus my suggestion
> >> > to reference the `--find-copies-harder` option to git-diff so that
> >> > affected users can get the info they need to choose.
> >>
> >> "in addition to paths that are different, will look for more copies
> >> even in unmodified paths" then?
> >
> > That's much better.  I still slightly prefer referencing
> > `--find-copies-harder` so that there's a link between "copies-harder"
> > and `--find-copies-harder`; but this version would also be fine.
>
> Oh, I didn't mean "use this rewrite and do not make any external
> reference".  More like "external reference is a good idea and
> necessary to help motivated readers, but we should give enough
> information inline, and I think this level of details would be
> sufficient".
Ah, gotcha.  Yeah, this sounds good.
Previous: Junio C HamanoNext: Sam James
Message 8 of 9 in “diff: implement config.diff.renames=copies-harder”
  1. diff: implement config.diff.renames=copies-harderSam James via GitGitGadget, Nov 3, 2023
  2. Elijah NewrenNov 7, 2023
  3. Junio C HamanoNov 7, 2023
  4. Elijah NewrenNov 7, 2023
  5. Junio C HamanoNov 8, 2023
  6. Elijah NewrenNov 8, 2023
  7. Junio C HamanoNov 8, 2023
  8. Elijah NewrenNov 8, 2023
  9. Sam JamesMar 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.