git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: implement config.diff.renames=copies-harder

From
Elijah Newren <newren@gmail.com>
Date
Nov 8, 2023, 03:30 UTC
Message-ID
<CABPp-BEgxKn3QvJQ+6L3Z1RN1im=c3dfApLRCrQqum_Yim44Gw@mail.gmail.com>
In-Reply-To
<xmqqttpx828i.fsf@gitster.g>
On Tue, Nov 7, 2023 at 5:26 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
>
> Elijah Newren <newren@gmail.com> writes:
>
> > I find that marginally better; but I still don't think it answers the
> > user's question of why they should pick one option or the other.  The
> > wording for the `--find-copies-harder` does explain when it's useful:
> >
> >         For performance reasons, by default, `-C` option finds copies only
> >         if the original file of the copy was modified in the same
> >         changeset.  This flag makes the command
> >         inspect unmodified files as candidates for the source of
> >         copy.  This is a very expensive operation for large
> >         projects, so use it with caution.
> >
> > We probably don't want to copy all three of those sentences here, but
> > I think we need to make sure users can find them, thus my suggestion
> > to reference the `--find-copies-harder` option to git-diff so that
> > affected users can get the info they need to choose.
>
> "in addition to paths that are different, will look for more copies
> even in unmodified paths" then?

That's much better. I still slightly prefer referencing `--find-copies-harder` so that there's a link between "copies-harder" and `--find-copies-harder`; but this version would also be fine.

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 9 in “diff: implement config.diff.renames=copies-harder”
  1. diff: implement config.diff.renames=copies-harderSam James via GitGitGadget, Nov 3, 2023
  2. Elijah NewrenNov 7, 2023
  3. Junio C HamanoNov 7, 2023
  4. Elijah NewrenNov 7, 2023
  5. Junio C HamanoNov 8, 2023
  6. Elijah NewrenNov 8, 2023
  7. Junio C HamanoNov 8, 2023
  8. Elijah NewrenNov 8, 2023
  9. Sam JamesMar 11, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.