Re: What's cooking in git.git (Mar 2023, #06; Wed, 29)

From: Elijah Newren <newren@gmail.com>
Date: Mar 30, 2023, 04:02 UTC
Message-ID: <CABPp-BHia5NO40-j=inCsroYn=J=+Zk12usNzL9keFFqTsghvg@mail.gmail.com>
In-Reply-To: <xmqqv8ij5g83.fsf@gitster.g>

On Wed, Mar 29, 2023 at 4:33 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 24 quoted lines

>
> * en/header-split-cleanup (2023-03-21) 16 commits
>  - csum-file.h: remove unnecessary inclusion of cache.h
>  - write-or-die.h: move declarations for write-or-die.c functions from cache.h
>  - treewide: remove cache.h inclusion due to setup.h changes
>  - setup.h: move declarations for setup.c functions from cache.h
>  - treewide: remove cache.h inclusion due to environment.h changes
>  - environment.h: move declarations for environment.c functions from cache.h
>  - treewide: remove unnecessary includes of cache.h
>  - wrapper.h: move declarations for wrapper.c functions from cache.h
>  - path.h: move function declarations for path.c functions from cache.h
>  - cache.h: remove expand_user_path()
>  - abspath.h: move absolute path functions from cache.h
>  - environment: move comment_line_char from cache.h
>  - treewide: remove unnecessary cache.h inclusion from several sources
>  - treewide: remove unnecessary inclusion of gettext.h
>  - treewide: be explicit about dependence on gettext.h
>  - treewide: remove unnecessary cache.h inclusion from a few headers
>
>  Split key function and data structure definitions out of cache.h to
>  new header files and adjust the users.
>
>  Needs review.
>  source: <pull.1493.v2.git.1679379968.gitgitgadget@gmail.com>

Not sure if you want more review, or the notice is just stale. If the latter, some helpful pointers:

Jonathan Tan reviewed the latest series, v2, here: https://lore.kernel.org/git/20230321215653.1615083-1-jonathantanmy@google.com/

(Ævar also looked at v1, and pointed out one of my commit messages needed clarification, and that my overall cover letter needed further explanation -- both of which were provided in v2).