Re: What's cooking in git.git (Mar 2023, #06; Wed, 29)

From: Elijah Newren <newren@gmail.com>
Date: Apr 1, 2023, 19:07 UTC
Message-ID: <CABPp-BGoPuGCZw+9wCgdYyRR4Zf4y9Kun27GrQhtMdYWpOUsYQ@mail.gmail.com>
In-Reply-To: <xmqqv8ij5g83.fsf@gitster.g>

Hi,

Just a comment on a couple series I've looked at today:

On Wed, Mar 29, 2023 at 4:33 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> * ad/test-record-count-when-harness-is-in-use (2022-12-25) 1 commit
>  - test-lib: allow storing counts with test harnesses
>
>  Allow summary results from tests to be written to t/test-results
>  directory even when a test harness like 'prove' is in use.
>
>  Needs review.
>  source: <20221224225200.1027806-1-adam@dinwoodie.org>

Maybe mark as expecting a re-roll? (based on Peff's review and your follow-up at https://lore.kernel.org/git/xmqqr0u1agq8.fsf@gitster.g/, plus the typo I just spotted in the commit message)?

Alternatively, if we want the --counts option (as per Peff's "The patch itself looks correct, if we want to go with a --counts option."), then just fixup the typo I spotted in the commit message (https://lore.kernel.org/git/CABPp-BGBYUHeYtsyM-gYvr0CsKGAmJ1OKqcmnHiKYy0ps6NrCg@mail.gmail.com/), and then merge it down?

Show 13 quoted lines

> * cw/submodule-status-in-parallel (2023-03-02) 6 commits
>  - diff-lib: parallelize run_diff_files for submodules
>  - diff-lib: refactor out diff_change logic
>  - submodule: refactor is_submodule_modified()
>  - submodule: move status parsing into function
>  - submodule: rename strbuf variable
>  - run-command: add on_stderr_output_fn to run_processes_parallel_opts
>
>  "git submodule status" learned to run the comparison in submodule
>  repositories in parallel.
>
>  Comments?
>  source: <20230302215237.1473444-1-calvinwan@google.com>

Perhaps this could be marked as needing a reroll, based on both https://lore.kernel.org/git/CAFySSZDk05m6gU5-V1R+y3YnQ5PPduVW54+_gjBwD0rmacsLsw@mail.gmail.com/ and https://lore.kernel.org/git/xmqqv8jczbs0.fsf@gitster.g/ ?