Re: [PATCH v4 01/11] t2501: add various tests for removing the current working directory

From: Elijah Newren <newren@gmail.com>
Date: Nov 30, 2021, 06:53 UTC
Message-ID: <CABPp-BHQsQqjCwjCUk-bSe_i52Wza-QgTDbHVsLn90D8q5FkuQ@mail.gmail.com>
In-Reply-To: <xmqqilwa2l8f.fsf@gitster.g>

On Mon, Nov 29, 2021 at 10:47 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>
> "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
> > +             # Although we want pwd & git status to pass, test for existing
> > +             # rather than desired behavior.
> > +             if test "$works" == "success"
>
> Don't double "=" here.  We are not writing for bash.  There are a
> few more instances of the same mistake in this patch.

Yep, also pointed out by Eric. I've got a v5 queued up whose change is just fixing this, but I'm waiting a bit to see if other items are spotted in review before sending.

Thanks for spotting.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.