Re: [PATCH v1 1/1] test: Correct detection of UTF8_NFD_TO_NFC for APFS

From: Elijah Newren <newren@gmail.com>
Date: Apr 30, 2018, 15:47 UTC
Message-ID: <CABPp-BH54kVUnHR3r=XH9b6RhnQ2NpFSqVUnNyQU6M9b1tywMg@mail.gmail.com>
In-Reply-To: <86b1fc05-b22c-cb9a-b5b5-d5e819d97c1e@web.de>

On Mon, Apr 30, 2018 at 8:41 AM, Torsten Bögershausen <tboegi@web.de> wrote:

Show 5 quoted lines

> On 30.04.18 17:33, Elijah Newren wrote:
>
>> On Sun, Apr 29, 2018 at 11:35 PM,  <tboegi@web.de> wrote:
>>> From: Torsten Bögershausen <tboegi@web.de>
>>>

Show 15 quoted lines

>>> @@ -1106,12 +1106,7 @@ test_lazy_prereq UTF8_NFD_TO_NFC '
>>
>> I'm not sure what "NFD" and "NFC" stand for, but I suspect the test
>> prerequisite name may be specific to how HFS handled things.  If so,
>> should it be renamed from UTF8_NFD_TO_NFC to something else, such as
>> UTF8_NORMALIZATION?
>
> NFD and NFC both come from the unicode standard, and are just taken
> "as is" into the Git world:
> https://en.wikipedia.org/wiki/Unicode_equivalence
>
> If you are otherwise happy with the patch, would it be possible
> to run it on your system ?
> (I don't have a High Sierra box, but I am confident that the test work
>  for you).

Sure, feel free to add a

Tested-by: Elijah Newren <newren@gmail.com>

if you like. (Works with both 'test -r', as in your patch, and 'test -f', as suggested by Junio.)