Re: BUG report: unicode normalization on APFS (Mac OS High Sierra)

From: Totsten Bögershausen <tboegi@web.de>
Date: Apr 27, 2018, 21:45 UTC
Message-ID: <7f9feab0-3638-56cd-18bb-4de0122aabad@web.de>
In-Reply-To: <CABPp-BHitvta8we8di-tFiNdVV7vXnMNAhiAs2=CrQc-gGuSJw@mail.gmail.com>

On 2018-04-26 19:23, Elijah Newren wrote:

Show 32 quoted lines

> On Thu, Apr 26, 2018 at 10:13 AM, Torsten Bögershausen <tboegi@web.de> wrote:
>> Hm,
>> thanks for the report.
>> I don't have a high sierra box, but I can probably get one.
>> t0050 -should- pass automagically, so I feel that I can do something.
>> Unless someone is faster of course.
> 
> Sweet, thanks for taking a look.
> 
>> Is it possible that  you run
>> debug=t verbose=t ./t0050-filesystem.sh
>> and send the output to me ?
> 
> Sure.  First, though, note that I can make it pass (or at least "not
> ok...TODO known breakage") with the following patch (may be
> whitespace-damaged by gmail):
> 
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 483c8d6d7..770b91f8c 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -1106,12 +1106,7 @@ test_lazy_prereq UTF8_NFD_TO_NFC '
>          auml=$(printf "\303\244")
>          aumlcdiar=$(printf "\141\314\210")
>          >"$auml" &&
> -       case "$(echo *)" in
> -       "$aumlcdiar")
> -               true ;;
> -       *)
> -               false ;;
> -       esac
> +       stat "$aumlcdiar" >/dev/null 2>/dev/null

Nicely analyzed and improved.

The "stat" statement is technically correct.
I think that a more git-style fix would be
[] ---
+       test -r "$aumlcdiar"

instead of the stat.

I looked into the 2 known breakages.
In short: they test use cases which are not sooo important for a user in 
practice, but do a good test if the code is broken.
IOW: I can't see a need for immediate action.

As you already did all the analyzes: Do you want to send a patch ?