Re: What's cooking in git.git (Nov 2020, #02; Mon, 9)

From: Elijah Newren <newren@gmail.com>
Date: Nov 10, 2020, 00:44 UTC
Message-ID: <CABPp-BGtO5bgoinmjc3=WwW+w7G4Js14iGvO_qQ6oF3EcQt7xQ@mail.gmail.com>
In-Reply-To: <xmqq7dqu9jwh.fsf@gitster.c.googlers.com>

On Mon, Nov 9, 2020 at 3:45 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 23 quoted lines

>
> * en/strmap (2020-11-06) 15 commits
>  - shortlog: use strset from strmap.h
>  - Use new HASHMAP_INIT macro to simplify hashmap initialization
>  - strmap: take advantage of FLEXPTR_ALLOC_STR when relevant
>  - strmap: enable allocations to come from a mem_pool
>  - strmap: add a strset sub-type
>  - strmap: split create_entry() out of strmap_put()
>  - strmap: add functions facilitating use as a string->int map
>  - strmap: enable faster clearing and reusing of strmaps
>  - strmap: add more utility functions
>  - strmap: new utility functions
>  - hashmap: provide deallocation function names
>  - hashmap: introduce a new hashmap_partial_clear()
>  - hashmap: allow re-use after hashmap_free()
>  - hashmap: adjust spacing to fix argument alignment
>  - hashmap: add usage documentation explaining hashmap_free[_entries]()
>  (this branch is used by en/merge-ort-impl.)
>
>  A speciailization of hashmap that uses a string as key has been
>  introduced.  Hopefully it will see wider use over time.
>
>  Will merge to 'next'?

Yes, please. Peff went over the series in detail and said it looked good to him as of v4 (he also seemed fine with the extra change in v5 that I made in response to your request). I'm not aware of any issues or further requests, and believe it is done. I'll CC Peff just in case he wants to change his mind and request any more changes here...

However, you have an extra 'i' in your spelling of 'specialization' when describing this series. You might want to fix that when merging to next.