git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Nov 2020, #02; Mon, 9)

From
Jeff King <peff@peff.net>
Date
Nov 10, 2020, 01:03 UTC
Message-ID
<20201110010346.GA1269097@coredump.intra.peff.net>
In-Reply-To
<CABPp-BGtO5bgoinmjc3=WwW+w7G4Js14iGvO_qQ6oF3EcQt7xQ@mail.gmail.com>
On Mon, Nov 09, 2020 at 04:44:17PM -0800, Elijah Newren wrote:
Show 9 quoted lines
> > * en/strmap (2020-11-06) 15 commits
> [...]
> >  Will merge to 'next'?
> 
> Yes, please.  Peff went over the series in detail and said it looked
> good to him as of v4 (he also seemed fine with the extra change in v5
> that I made in response to your request).  I'm not aware of any issues
> or further requests, and believe it is done.  I'll CC Peff just in
> case he wants to change his mind and request any more changes here...

I actually forgot to look over your strset_add() function carefully, so thanks for the reminder. :) It all looks good to me. Obviously the boolean return is flipped from my strset_check_and_add(), but I can't really think of a reason to prefer one over the other.

-Peff
Previous: Elijah NewrenNext: Derrick Stolee
Message 3 of 15 in “What's cooking in git.git (Nov 2020, #02; Mon, 9)”
  1. Junio C HamanoNov 9, 2020
  2. Elijah NewrenNov 10, 2020
  3. Jeff KingNov 10, 2020
  4. ds/maintenance-part-3 (was Re: What's cooking in git.git (Nov 2020, #02; Mon, 9))Derrick Stolee, Nov 10, 2020
  5. Emily ShafferNov 16, 2020
  6. Junio C HamanoNov 17, 2020
  7. Emily ShafferNov 17, 2020
  8. Derrick StoleeNov 17, 2020
  9. Emily ShafferNov 17, 2020
  10. Junio C HamanoNov 17, 2020
  11. Derrick StoleeNov 17, 2020
  12. Junio C HamanoNov 19, 2020
  13. Derrick StoleeNov 19, 2020
  14. Derrick StoleeNov 19, 2020
  15. Junio C HamanoNov 19, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.