Re: Raise your hand to Ack jk/code-of-conduct if your Ack fell thru cracks

From: Elijah Newren <newren@gmail.com>
Date: Oct 9, 2019, 18:29 UTC
Message-ID: <CABPp-BGjaOofi_gWEatKnnkpY04OOyMDZucXqQ-FPYw8yeCacw@mail.gmail.com>
In-Reply-To: <xmqqd0f6n5a4.fsf_-_@gitster-ct.c.googlers.com>

On Tue, Oct 8, 2019 at 5:20 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 22 quoted lines

>
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> > In other words, the commit message can be augmented by this:
> >
> > Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > Acked-by: Derrick Stolee <stolee@gmail.com>
> > Acked-by: Garima Singh <garimasigit@gmail.com>
> > Acked-by: Jonathan Tan <jonathantanmy@google.com>
> > Acked-by: Thomas Gummerer <t.gummerer@gmail.com>
> > Acked-by: brian m. carlson <sandals@crustytoothpaste.net>
> > Acked-by: Elijah Newren <newren@gmail.com>
> >
> > Junio, would you mind picking it up, please?
>
> I trust you enough that I won't go back to the cited messages to
> double check that these acks are real, but I'd still wait for a few
> days for people who expressed their Acks but your scan missed, or
> those who wanted to give their Acks but forgot to do so, to raise
> their hands on this thread.
>
> Thanks for starting the concluding move on this topic.

Agreed, thanks. There is one super minor issue, that I probably shouldn't even bring up but... Looking at jk/coc, it ends with:

Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Christian Couder <chriscool@tuxfamily.org>
Acked-by: Emily Shaffer <emilyshaffer@google.com>
Acked-by: Garima Singh <garimasigit@gmail.com>
Acked-by: Junio C Hamano <gitster@pobox.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Jonathan Tan <jonathantanmy@google.com>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Taylor Blau <me@ttaylorr.com>
Acked-by: Elijah Newren <newren@gmail.com>
Acked-by: brian m. carlson <sandals@crustytoothpaste.net>
Acked-by: Derrick Stolee <stolee@gmail.com>
Acked-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Those Acked-by's are nearly in alphabetical order (at least at first glance) until Brian, Derrick, and me. I know it's a trivial thing, but for the OCD among us, could it either be randomized, ordered by when people acked, or alphabetized? Sorry if this sounds really trivial, but it's kind of like trying to hold a conversation with someone at their office when the cord to their phone was all twisted up; it's really difficult to pay attention to anything of substance until that problem is fixed (though, thankfully, a job change in combination with cell phone prevalence have almost completely eradicated the phone cord problem years ago).

I'm kinda worried that sending this will result in someone alphabetizing everyone in the list except me, but oh well...

Elijah