en/present-despite-skipped (Was: Re: What's cooking in git.git (Feb 2022, #07; Fri, 25))

From: Elijah Newren <newren@gmail.com>
Date: Feb 26, 2022, 09:11 UTC
Message-ID: <CABPp-BGX1+5KYeKLmUv4GN1--G5G0x0pRLxa9RRFBDSzkBc9AA@mail.gmail.com>
In-Reply-To: <xmqqee3q73e1.fsf@gitster.g>

On Fri, Feb 25, 2022 at 7:07 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 18 quoted lines

>
> * en/present-despite-skipped (2022-02-25) 7 commits
>  - repo_read_index: add config to expect files outside sparse patterns
>   (merged to 'next' on 2022-02-15 at 960873fdad)
>  + Accelerate clear_skip_worktree_from_present_files() by caching
>  + Update documentation related to sparsity and the skip-worktree bit
>  + repo_read_index: clear SKIP_WORKTREE bit from files present in worktree
>  + unpack-trees: fix accidental loss of user changes
>  + t1011: add testcase demonstrating accidental loss of user modifications
>  + Merge branch 'vd/sparse-clean-etc' into en/present-despite-skipped
>
>  In sparse-checkouts, files mis-marked as missing from the working tree
>  could lead to later problems.  Such files were hard to discover, and
>  harder to correct.  Automatically detecting and correcting the marking
>  of such files has been added to avoid these problems.
>
>  Will merge to 'next'?
>  source: <pull.1114.v2.git.1642175983.gitgitgadget@gmail.com>

Clearly you're asking about the bonus/final patch, since the others are already merged to next. I think it's now ready, but I did just send a v4 at [0] that hasn't been explicitly acked yet. However, in terms of prior acks:

Jonathan already gave his Reviewed-by on v3 at [1], though he also provided some wording suggestions for the docs. I rolled those and your suggestions into the v4.

Stolee sounded like he was happy with v1 in [2] ("This patch looks like a good solution to the concerns...Should we update [the docs]?...The only concern here really is if we want to be picky about...references in the commit message.") and seemed to agree with the rename of the option in [3] ("Creating a sparse.* namespace is a good idea.")

Dscho never acked it, but his multiple suggestions on wording and config naming suggest he was otherwise okay with the patch in general.

[0] https://lore.kernel.org/git/20220226061222.797107-1-newren@gmail.com/ [1] https://lore.kernel.org/git/YhkE2vxI4nM3ut0K@google.com/ [2] https://lore.kernel.org/git/54a0aa74-57c2-ee65-ae07-cb1b0daf947f@github.com/ [3] https://lore.kernel.org/git/d33e3253-dc2f-18a7-04b7-2c8a44405f6b@github.com/