ab/test-lib-tweaks (was: What's cooking in git.git (Feb 2022, #07; Fri, 25))

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Feb 28, 2022, 14:10 UTC
Message-ID: <220228.86tucj3wo2.gmgdl@evledraar.gmail.com>
In-Reply-To: <xmqqee3q73e1.fsf@gitster.g>

On Fri, Feb 25 2022, Junio C Hamano wrote:

Show 10 quoted lines

> * ab/test-lib-tweaks (2022-02-21) 4 commits
>  - test-lib: add "fast_unwind_on_malloc=0" to LSAN_OPTIONS
>  - test-lib: make $GIT_BUILD_DIR an absolute path
>  - test-lib: correct commentary on TEST_DIRECTORY overriding
>  - test-lib: add GIT_SAN_OPTIONS, inherit [AL]SAN_OPTIONS
>
>  Random test-framework clean-up.
>
>  Will merge to 'next'?
>  source: <cover-v3-0.4-00000000000-20220221T155656Z-avarab@gmail.com>

I sent a very minor v4 re-roll of this which should be ready for "next", i.e. it addresses comments (including yours) on the v3: https://lore.kernel.org/git/cover-v4-0.4-00000000000-20220227T102256Z-avarab@gmail.com/

If you're considering branch name/log message changes before merging (it would be fine without) I'd suggest:

    ab/test-lib-leak-diagnostics
    
    Spend more CPU to emit meaningful stack traces when testing under
    SANITIZE=leak, and allow overriding ASAN and LSAN options from the
    environment without breaking our tests in cases where they relied on
    setting their own options.