Re: [PATCH v2] fast-import: disallow more path components

From: Elijah Newren <newren@gmail.com>
Date: Dec 3, 2024, 08:01 UTC
Message-ID: <CABPp-BGP8zrSzxcacTzLY-EuYAQW5EwyDGNAMh196udGN18fmg@mail.gmail.com>
In-Reply-To: <20241201214014.GC145938@coredump.intra.peff.net>

On Sun, Dec 1, 2024 at 1:40 PM Jeff King <peff@peff.net> wrote:

Show 12 quoted lines

>
> On Sat, Nov 30, 2024 at 01:09:29AM +0000, Elijah Newren via GitGitGadget wrote:
>
> >     Changes since v1:
> >
> >      * Moved the check to a higher level, as suggested by Peff.
>
> Thanks, the code change looks good. Is it worth tweaking one of the
> tests to do "R innocent-path .git/evil"? Otherwise I don't think there's
> any coverage of the file_change_cr() call at all.
>
> -Peff

I would say yes, but since this patch too has made it to next and is marked for master, I'm kinda tempted to just leave it as-is...