git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] fast-import: disallow more path components

From
Jeff King <peff@peff.net>
Date
Dec 1, 2024, 21:40 UTC
Message-ID
<20241201214014.GC145938@coredump.intra.peff.net>
In-Reply-To
<pull.1832.v2.git.1732928970059.gitgitgadget@gmail.com>
On Sat, Nov 30, 2024 at 01:09:29AM +0000, Elijah Newren via GitGitGadget wrote:
>     Changes since v1:
>     
>      * Moved the check to a higher level, as suggested by Peff.

Thanks, the code change looks good. Is it worth tweaking one of the tests to do "R innocent-path .git/evil"? Otherwise I don't think there's any coverage of the file_change_cr() call at all.

-Peff
Previous: Elijah Newren via GitGitGadgetNext: Elijah Newren
Message 5 of 11 in “fast-import: disallow more path components”
  1. fast-import: disallow more path componentsElijah Newren via GitGitGadget, Nov 27, 2024
  2. Junio C HamanoNov 28, 2024
  3. Jeff KingNov 28, 2024
  4. fast-import: disallow more path componentsElijah Newren via GitGitGadget, Nov 30, 2024
  5. Jeff KingDec 1, 2024
  6. Elijah NewrenDec 3, 2024
  7. 2/1 t9300: test verification of renamed pathsJeff King, Dec 3, 2024
  8. Elijah NewrenDec 3, 2024
  9. Junio C HamanoDec 4, 2024
  10. Junio C HamanoDec 3, 2024
  11. Junio C HamanoDec 2, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.