Re: [PATCH 15/27] sparse-checkout: ensure full index
- From
Elijah Newren <newren@gmail.com>
- Date
- Mar 18, 2021, 05:22 UTC
- Message-ID
- <CABPp-BF4YVSNB1c=y11MZfTDAu=KHryNb5JQZ1kKRpigPALPxw@mail.gmail.com>
- In-Reply-To
- <92ccd31dd343c20bad4a6b8d89c50559209e7236.1615929436.git.gitgitgadget@gmail.com>
On Tue, Mar 16, 2021 at 2:17 PM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 7 quoted lines
> > From: Derrick Stolee <dstolee@microsoft.com> > > When adjusting the sparse-checkout definition, ensure that a sparse > index is expanded to a full one to avoid unexpected behavior. This is a > top candidate for later integration with the sparse-index, but requires > careful testing.
I was going to comment on most of these collectively, but your commit message is completely divorced from the patch; it appears you either place the wrong commit message here or copied it from the one for a sparse-checkout. The code modifies stash, though.
Show 19 quoted lines
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > builtin/stash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/builtin/stash.c b/builtin/stash.c > index ba774cce674f..b3d4fe814b6b 100644 > --- a/builtin/stash.c > +++ b/builtin/stash.c > @@ -1350,6 +1350,7 @@ static int do_push_stash(const struct pathspec *ps, const char *stash_msg, int q > int i; > char *ps_matched = xcalloc(ps->nr, 1); > > + ensure_full_index(&the_index); > for (i = 0; i < active_nr; i++) > ce_path_match(&the_index, active_cache[i], ps, > ps_matched); > -- > gitgitgadget