Re: [PATCH 12/27] sparse-index: check index conversion happens
- From
Elijah Newren <newren@gmail.com>
- Date
- Jan 27, 2021, 17:46 UTC
- Message-ID
- <CABPp-BEOQi1JF-S7XMNTAns0ckbikokk+-Rvw3peCFgts5D27w@mail.gmail.com>
- In-Reply-To
- <9b2ae1bb6c49b67cc17691d58044bbb8efb114a3.1611596534.git.gitgitgadget@gmail.com>
On Mon, Jan 25, 2021 at 9:42 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 28 quoted lines
> > From: Derrick Stolee <dstolee@microsoft.com> > > Add a test case that uses test_region to ensure that we are truly > expanding a sparse index to a full one, then converting back to sparse > when writing the index. As we integrate more Git commands with the > sparse index, we will convert these commands to check that we do _not_ > convert the sparse index to a full index and instead stay sparse the > entire time. > > Signed-off-by: Derrick Stolee <dstolee@microsoft.com> > --- > t/t1092-sparse-checkout-compatibility.sh | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh > index 22becbaca2e..a22def89e37 100755 > --- a/t/t1092-sparse-checkout-compatibility.sh > +++ b/t/t1092-sparse-checkout-compatibility.sh > @@ -374,4 +374,21 @@ test_expect_success 'clean' ' > test_sparse_match test_path_is_dir folder1 > ' > > +test_expect_success 'sparse-index is expanded and converted back' ' > + init_repos && > + > + ( > + (GIT_TEST_SPARSE_INDEX=1 && export GIT_TEST_SPARSE_INDEX) &&
Drop the parentheses.
What system are you running on that this test passed for you with those parentheses there? I checked out this particular commit and ran the test -- and it fails for me. Removing the parentheses makes the test pass.
Is there some shell where parentheses only function as grouping, similar to bash's {...}, rather than as a subshell, the way bash handles (...) ?
Show 15 quoted lines
> + GIT_TRACE2_EVENT="$(pwd)/trace2.txt" GIT_TRACE2_EVENT_NESTING=10 \ > + git -C sparse-index -c core.fsmonitor="" reset --hard && > + test_region index convert_to_sparse trace2.txt && > + test_region index ensure_full_index trace2.txt && > + > + rm trace2.txt && > + GIT_TRACE2_EVENT="$(pwd)/trace2.txt" GIT_TRACE2_EVENT_NESTING=10 \ > + git -C sparse-index -c core.fsmonitor="" status -uno && > + test_region index ensure_full_index trace2.txt > + ) > +' > + > test_done > -- > gitgitgadget
Otherwise, I like the test and this commit.