Re: [PATCH 08/27] sparse-checkout: hold pattern list in index

From: Derrick Stolee <stolee@gmail.com>
Date: Jan 28, 2021, 13:12 UTC
Message-ID: <87467655-aafb-d509-5158-5688543e5868@gmail.com>
In-Reply-To: <CABPp-BEA5B3TzA-w-aBC1ZvFEYzvZfB-hkc=rXqgSVjrBNTLcA@mail.gmail.com>

On 1/27/2021 12:00 PM, Elijah Newren wrote:

Show 16 quoted lines

> On Mon, Jan 25, 2021 at 9:42 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Derrick Stolee <dstolee@microsoft.com>
>>
>> As we modify the sparse-checkout definition, we perform index operations
>> on a pattern_list that only exists in-memory. This allows easy backing
>> out in case the index update fails.
>>
>> However, if the index write itself cares about the sparse-checkout
>> pattern set, we need access to that in-memory copy. Place a pointer to
>> a 'struct pattern_list' in the index so we can access this on-demand.
>> This will be used in the next change which uses the sparse-checkout
>> definition to filter out directories that are outsie the sparse cone.
> 
> s/outsie/outside/

Thanks!

> Isn't this the same patch you put in your index cleanup series, or am
> I getting confused?  It looks very familiar.

 
I removed it from v2 of that series because it didn't do anything of
value until we start using the sparse_checkout_patterns member in the
next patch of _this_ series.

Thanks, -Stolee