Re: [PATCH 2/2] On Cygwin support both UNIX and DOS style path-names
- From
Erik Faye-Lund <kusmabite@gmail.com>
- Date
- Aug 5, 2011, 17:51 UTC
- Message-ID
- <CABPQNSb2O2JrQ8QeRAq5teizmRzE-b=dDKKB=ba-=DL3eDPL6w@mail.gmail.com>
- In-Reply-To
- <CABPQNSYQ9D7NO5cx_o3csAe4bQ40kOd1f5gATUXDb7r4n3GhdA@mail.gmail.com>
On Fri, Aug 5, 2011 at 7:39 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
Show 24 quoted lines
> On Fri, Aug 5, 2011 at 7:35 PM, Pascal Obry <pascal@obry.net> wrote: >> Le 05/08/2011 19:29, Erik Faye-Lund a écrit : >>> >>> Cygwin is a unix-layer on top of Windows, designed to play by the >>> POSIX-rules. So why would you want to support Windows-style paths on >>> Cygwin? >> >> Because cygwin toolset does support \. >> > > Are you saying that the built-in Cygwin tools (like ls etc) support > Windows-style paths (C:\path\to\file)? If that is the case, I > completely understand the desire to accept Windows-paths. > >>> If you want a Git that handles Windows paths, use Git for Windows... >> >> Note that Windows is a special case as even the Win32 API does support \ and >> /, so every tool on Windows seems to handle nicely this. Why not Git, be it >> Cygwin/Git. If it does not break anything else. > > If the Cygwin-tools does not support drive-prefixes (i.e "C:\") but > does support both slashes as path-separators, then I agree with the > patch but not with the commit message. >
correction: if that is the case, I agree with the is_dir_sep-part, but not the has_dos_drive_prefix-part of the patch (and also not the example from the commit message)